linux-kernel - Re: [PATCH 1/2] arm64: dts: qcom: minor whitespace cleanup around '='

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZKKXGE95Sv-eLQa8@hovoldconsulting.com>
Date:   Mon, 3 Jul 2023 11:38:32 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        cros-qcom-dts-watchers@...omium.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: minor whitespace cleanup around '='

On Mon, Jul 03, 2023 at 11:30:24AM +0200, Konrad Dybcio wrote:
> On 2.07.2023 20:50, Krzysztof Kozlowski wrote:
> > The DTS code coding style expects exactly one space before and after '='
> > sign.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > ---

[...]
 
> > diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi
> > index 895cafc11480..c4209e2d4b4e 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi
> > @@ -155,7 +155,7 @@ CPU7: cpu@3 {
> >  
> >  		idle-states {
> >  			CPU_SLEEP_0: cpu-sleep-0 {
> > -				compatible ="qcom,idle-state-spc", "arm,idle-state";
> > +				compatible = "qcom,idle-state-spc", "arm,idle-state";
> Will conflict with:
> 
> https://lore.kernel.org/linux-arm-msm/20230627-topic-more_bindings-v1-2-6b4b6cd081e5@linaro.org/
> 
> there are also a couple of entries with property =\n\t{n}[a-z]
> 
> Otherwise lgtm
 
Konrad, please remember to trim irrelevant context from your replies
(e.g. so that we don't have to skim through thousands of lines to find
a single comment).

Johan