| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230703105552.5acf5f9f@canb.auug.org.au>
Date: Mon, 3 Jul 2023 10:55:52 +1000
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: Anup Patel <anup@...infault.org>,
Palmer Dabbelt <palmer@...belt.com>,
Paul Walmsley <paul@...an.com>,
Andy Chiu <andy.chiu@...ive.com>,
Anup Patel <apatel@...tanamicro.com>,
Greentime Hu <greentime.hu@...ive.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux Next Mailing List <linux-next@...r.kernel.org>,
Vincent Chen <vincent.chen@...ive.com>,
KVM <kvm@...r.kernel.org>
Subject: Re: linux-next: manual merge of the kvm-riscv tree with the risc-v
tree
Hi all,
On Tue, 20 Jun 2023 12:45:33 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Today's linux-next merge of the kvm-riscv tree got a conflict in:
>
> arch/riscv/include/uapi/asm/kvm.h
>
> between commit:
>
> bf78f1ea6e51 ("riscv: kvm: Add V extension to KVM ISA")
>
> from the risc-v tree and commit:
>
> 3177011788ee ("RISC-V: KVM: Allow Svnapot extension for Guest/VM")
>
> from the kvm-riscv tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
>
> diff --cc arch/riscv/include/uapi/asm/kvm.h
> index 855c047e86d4,a1ca18408bbd..000000000000
> --- a/arch/riscv/include/uapi/asm/kvm.h
> +++ b/arch/riscv/include/uapi/asm/kvm.h
> @@@ -121,7 -122,7 +122,8 @@@ enum KVM_RISCV_ISA_EXT_ID
> KVM_RISCV_ISA_EXT_ZICBOZ,
> KVM_RISCV_ISA_EXT_ZBB,
> KVM_RISCV_ISA_EXT_SSAIA,
> + KVM_RISCV_ISA_EXT_V,
> + KVM_RISCV_ISA_EXT_SVNAPOT,
> KVM_RISCV_ISA_EXT_MAX,
> };
>
> @@@ -204,13 -205,77 +206,84 @@@ enum KVM_RISCV_SBI_EXT_ID
> #define KVM_REG_RISCV_SBI_MULTI_REG_LAST \
> KVM_REG_RISCV_SBI_MULTI_REG(KVM_RISCV_SBI_EXT_MAX - 1)
>
> +/* V extension registers are mapped as type 9 */
> +#define KVM_REG_RISCV_VECTOR (0x09 << KVM_REG_RISCV_TYPE_SHIFT)
> +#define KVM_REG_RISCV_VECTOR_CSR_REG(name) \
> + (offsetof(struct __riscv_v_ext_state, name) / sizeof(unsigned long))
> +#define KVM_REG_RISCV_VECTOR_REG(n) \
> + ((n) + sizeof(struct __riscv_v_ext_state) / sizeof(unsigned long))
> +
> + /* Device Control API: RISC-V AIA */
> + #define KVM_DEV_RISCV_APLIC_ALIGN 0x1000
> + #define KVM_DEV_RISCV_APLIC_SIZE 0x4000
> + #define KVM_DEV_RISCV_APLIC_MAX_HARTS 0x4000
> + #define KVM_DEV_RISCV_IMSIC_ALIGN 0x1000
> + #define KVM_DEV_RISCV_IMSIC_SIZE 0x1000
> +
> + #define KVM_DEV_RISCV_AIA_GRP_CONFIG 0
> + #define KVM_DEV_RISCV_AIA_CONFIG_MODE 0
> + #define KVM_DEV_RISCV_AIA_CONFIG_IDS 1
> + #define KVM_DEV_RISCV_AIA_CONFIG_SRCS 2
> + #define KVM_DEV_RISCV_AIA_CONFIG_GROUP_BITS 3
> + #define KVM_DEV_RISCV_AIA_CONFIG_GROUP_SHIFT 4
> + #define KVM_DEV_RISCV_AIA_CONFIG_HART_BITS 5
> + #define KVM_DEV_RISCV_AIA_CONFIG_GUEST_BITS 6
> +
> + /*
> + * Modes of RISC-V AIA device:
> + * 1) EMUL (aka Emulation): Trap-n-emulate IMSIC
> + * 2) HWACCEL (aka HW Acceleration): Virtualize IMSIC using IMSIC guest files
> + * 3) AUTO (aka Automatic): Virtualize IMSIC using IMSIC guest files whenever
> + * available otherwise fallback to trap-n-emulation
> + */
> + #define KVM_DEV_RISCV_AIA_MODE_EMUL 0
> + #define KVM_DEV_RISCV_AIA_MODE_HWACCEL 1
> + #define KVM_DEV_RISCV_AIA_MODE_AUTO 2
> +
> + #define KVM_DEV_RISCV_AIA_IDS_MIN 63
> + #define KVM_DEV_RISCV_AIA_IDS_MAX 2048
> + #define KVM_DEV_RISCV_AIA_SRCS_MAX 1024
> + #define KVM_DEV_RISCV_AIA_GROUP_BITS_MAX 8
> + #define KVM_DEV_RISCV_AIA_GROUP_SHIFT_MIN 24
> + #define KVM_DEV_RISCV_AIA_GROUP_SHIFT_MAX 56
> + #define KVM_DEV_RISCV_AIA_HART_BITS_MAX 16
> + #define KVM_DEV_RISCV_AIA_GUEST_BITS_MAX 8
> +
> + #define KVM_DEV_RISCV_AIA_GRP_ADDR 1
> + #define KVM_DEV_RISCV_AIA_ADDR_APLIC 0
> + #define KVM_DEV_RISCV_AIA_ADDR_IMSIC(__vcpu) (1 + (__vcpu))
> + #define KVM_DEV_RISCV_AIA_ADDR_MAX \
> + (1 + KVM_DEV_RISCV_APLIC_MAX_HARTS)
> +
> + #define KVM_DEV_RISCV_AIA_GRP_CTRL 2
> + #define KVM_DEV_RISCV_AIA_CTRL_INIT 0
> +
> + /*
> + * The device attribute type contains the memory mapped offset of the
> + * APLIC register (range 0x0000-0x3FFF) and it must be 4-byte aligned.
> + */
> + #define KVM_DEV_RISCV_AIA_GRP_APLIC 3
> +
> + /*
> + * The lower 12-bits of the device attribute type contains the iselect
> + * value of the IMSIC register (range 0x70-0xFF) whereas the higher order
> + * bits contains the VCPU id.
> + */
> + #define KVM_DEV_RISCV_AIA_GRP_IMSIC 4
> + #define KVM_DEV_RISCV_AIA_IMSIC_ISEL_BITS 12
> + #define KVM_DEV_RISCV_AIA_IMSIC_ISEL_MASK \
> + ((1U << KVM_DEV_RISCV_AIA_IMSIC_ISEL_BITS) - 1)
> + #define KVM_DEV_RISCV_AIA_IMSIC_MKATTR(__vcpu, __isel) \
> + (((__vcpu) << KVM_DEV_RISCV_AIA_IMSIC_ISEL_BITS) | \
> + ((__isel) & KVM_DEV_RISCV_AIA_IMSIC_ISEL_MASK))
> + #define KVM_DEV_RISCV_AIA_IMSIC_GET_ISEL(__attr) \
> + ((__attr) & KVM_DEV_RISCV_AIA_IMSIC_ISEL_MASK)
> + #define KVM_DEV_RISCV_AIA_IMSIC_GET_VCPU(__attr) \
> + ((__attr) >> KVM_DEV_RISCV_AIA_IMSIC_ISEL_BITS)
> +
> + /* One single KVM irqchip, ie. the AIA */
> + #define KVM_NR_IRQCHIPS 1
> +
> #endif
>
> #endif /* __LINUX_KVM_RISCV_H */
This is now a conflict between the kvm tree and Linus' tree.
--
Cheers,
Stephen Rothwell
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists