linux-kernel - Re: [PATCH] ARM: dts: st: add buswidth property to stm32f429-disco

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4aba0e4a-87f0-1810-bf4d-a2f278e51e8b@gmail.com>
Date:   Mon, 3 Jul 2023 05:25:08 +0200
From:   Raphaël Gallais-Pou <rgallaispou@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>
Cc:     devicetree@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: st: add buswidth property to stm32f429-disco

Hi,

Le 02/07/2023 à 22:14, Krzysztof Kozlowski a écrit :
> On 02/07/2023 12:35, Raphael Gallais-Pou wrote:
>> The ili9341 is left without a mandatory buswidth to properly communicate
>> between the SI bus and the display. Add the device-tree property.
>>
>> Signed-off-by: Raphael Gallais-Pou <rgallaispou@...il.com>
>> ---
>>   arch/arm/boot/dts/stm32f429-disco.dts | 1 +
> 
> There is no such file. Please rebase on recent Linux.

Yes, indeed. I forgot to pull, I'm sorry.

> 
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32f429-disco.dts b/arch/arm/boot/dts/stm32f429-disco.dts
>> index 3b81228d46a2..5eaf95afc8c7 100644
>> --- a/arch/arm/boot/dts/stm32f429-disco.dts
>> +++ b/arch/arm/boot/dts/stm32f429-disco.dts
>> @@ -197,6 +197,7 @@ display: display@1{
>>   		spi-3wire;
>>   		spi-max-frequency = <10000000>;
>>   		dc-gpios = <&gpiod 13 0>;
>> +		buswidth = <8>;
> 
> There is no such spi property.

While I agree with you, I saw in staging drivers that this property was 
fetch in the device-tree by the fbtft core.

Should I document those in or try to do it another way ?

> 
> Best regards,
> Krzysztof
> 

Thanks,
Raphaël