linux-kernel - Re: [PATCH v1] drivers: use free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69e863ac-192d-2f63-62bb-8decdd719282@cambridgegreys.com>
Date:   Mon, 3 Jul 2023 11:12:36 +0100
From:   Anton Ivanov <anton.ivanov@...bridgegreys.com>
To:     Minjie Du <duminjie@...o.com>, richard@....at,
        johannes@...solutions.net, sfr@...b.auug.org.au,
        linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org,
        machel@...o.com
Cc:     opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers: use free_netdev before return



On 03/07/2023 10:41, Minjie Du wrote:
> We fixed a bug where the variable dev
> was not freed before return.
> 
> Signed-off-by: Minjie Du <duminjie@...o.com>
> ---
>   arch/um/drivers/vector_kern.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> index 131b7cb29..af7f6fd4c 100644
> --- a/arch/um/drivers/vector_kern.c
> +++ b/arch/um/drivers/vector_kern.c
> @@ -1655,6 +1655,7 @@ static void vector_eth_configure(
>   	return;
>   
>   out_undo_user_init:

undo_user_init looks like an orphan from older code versions.

It should go away completely - jump to out_free_netdev instead.

> +	free_netdev(dev);
>   	return;
>   out_free_netdev:
>   	free_netdev(dev);

-- 
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/