linux-kernel - Re: [PATCH v2] PCI: rockchip: Use 64-bit mask on MSI 64-bit PCI address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAEEuhpP+9ofqDqxL7NEfw5C5KTn-z=kQktgo_3d_w=w1pc+Eg@mail.gmail.com>
Date:   Mon, 3 Jul 2023 14:59:39 +0200
From:   Rick Wertenbroek <rick.wertenbroek@...il.com>
To:     Krzysztof Wilczyński <kw@...ux.com>
Cc:     Robin Murphy <robin.murphy@....com>, alberto.dassatti@...g-vd.ch,
        dlemoal@...nel.org, Dan Carpenter <dan.carpenter@...aro.org>,
        stable@...r.kernel.org, Shawn Lin <shawn.lin@...k-chips.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Heiko Stuebner <heiko@...ech.de>, linux-pci@...r.kernel.org,
        linux-rockchip@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] PCI: rockchip: Use 64-bit mask on MSI 64-bit PCI address

On Mon, Jul 3, 2023 at 2:08 PM Krzysztof Wilczyński <kw@...ux.com> wrote:
>
> Hello,
>
> > > A 32-bit mask was used on the 64-bit PCI address used for mapping MSIs.
> > > This would result in the upper 32 bits being unintentionally zeroed and
> > > MSIs getting mapped to incorrect PCI addresses if the address had any
> > > of the upper bits set.
> > >
> > > Replace 32-bit mask by appropriate 64-bit mask.
>
> [...]
> > > +#define PCIE_ADDR_MASK                     GENMASK(63, MIN_AXI_ADDR_BITS_PASSED)
> >
> > Nit: this probably wants to be GENMASK_ULL(), otherwise it might throw a
> > warning if compile-tested for 32-bit.
>
> I can change this to GENMASK_ULL() when I apply the patch.  Unless Rick
> wants to send v3 - either way would be fine. :)
>
>         Krzysztof

Thank you, I'd appreciate that rather than sending a v3.

Regards,
Rick