[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d1cfb1fb-d347-16d8-4446-dddcf8200638@linaro.org>
Date: Mon, 3 Jul 2023 15:12:08 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: =Xianwei Zhao <xianwei.zhao@...ogic.com>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Neil Armstrong <neil.armstrong@...aro.org>,
Kevin Hilman <khilman@...libre.com>
Subject: Re: [PATCH 1/3] dt-bindings: power: add Amlogic C3 power domains
On 03/07/2023 11:31, =Xianwei Zhao wrote:
> From: Xianwei Zhao <xianwei.zhao@...ogic.com>
>
> Add devicetree binding document and related header file for Amlogic C3 secure power domains.
>
> Signed-off-by: Xianwei Zhao <xianwei.zhao@...ogic.com>
> ---
> .../power/amlogic,meson-sec-pwrc.yaml | 3 ++-
> include/dt-bindings/power/amlogic-c3-power.h | 26 +++++++++++++++++++
> 2 files changed, 28 insertions(+), 1 deletion(-)
> create mode 100644 include/dt-bindings/power/amlogic-c3-power.h
>
> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> index eab21bb2050a..d80bbedfe3aa 100644
> --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> @@ -12,7 +12,7 @@ maintainers:
> - Jianxin Pan <jianxin.pan@...ogic.com>
>
> description: |+
> - Secure Power Domains used in Meson A1/C1/S4 SoCs, and should be the child node
> + Secure Power Domains used in Meson A1/C1/S4 & C3 SoCs, and should be the child node
> of secure-monitor.
>
> properties:
> @@ -20,6 +20,7 @@ properties:
> enum:
> - amlogic,meson-a1-pwrc
> - amlogic,meson-s4-pwrc
> + - amlogic,c3-pwrc
>
> "#power-domain-cells":
> const: 1
> diff --git a/include/dt-bindings/power/amlogic-c3-power.h b/include/dt-bindings/power/amlogic-c3-power.h
> new file mode 100644
> index 000000000000..3403e7c0b49d
> --- /dev/null
> +++ b/include/dt-bindings/power/amlogic-c3-power.h
Filename matching compatibles, please.
> @@ -0,0 +1,26 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */
> +/*
> + * Copyright (c) 2023 Amlogic, Inc.
> + * Author: hongyu chen1 <hongyu.chen1@...ogic.com>
> + */
> +#ifndef _DT_BINDINGS_AMLOGIC_C3_POWER_H
> +#define _DT_BINDINGS_AMLOGIC_C3_POWER_H
> +
> +#define PWRC_C3_NNA_ID 0
> +#define PWRC_C3_AUDIO_ID 1
> +#define PWRC_C3_RESV_SEC_ID 2
> +#define PWRC_C3_SDIOA_ID 3
> +#define PWRC_C3_EMMC_ID 4
> +#define PWRC_C3_USB_COMB_ID 5
> +#define PWRC_C3_SDCARD_ID 6
> +#define PWRC_C3_ETH_ID 7
> +#define PWRC_C3_RESV0_ID 8
> +#define PWRC_C3_GE2D_ID 9
> +#define PWRC_C3_CVE_ID 10
> +#define PWRC_C3_GDC_WRAP_ID 11
> +#define PWRC_C3_ISP_TOP_ID 12
> +#define PWRC_C3_MIPI_ISP_WRAP_ID 13
> +#define PWRC_C3_VCODEC_ID 14
> +
> +#endif
> +
No need for stray blank line.
Best regards,
Krzysztof
Powered by blists - more mailing lists