linux-kernel - Re: [PATCH v1 2/3] gpiolib: acpi: Don't use GPIO chip fwnode in acpi_gpiochip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZKLJ4TxK5t2TWjUW@smile.fi.intel.com>
Date:   Mon, 3 Jul 2023 16:15:13 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        linux-gpio@...r.kernel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: Re: [PATCH v1 2/3] gpiolib: acpi: Don't use GPIO chip fwnode in
 acpi_gpiochip_find()

On Mon, Jul 03, 2023 at 03:18:37PM +0300, Andy Shevchenko wrote:

...

>  static int acpi_gpiochip_find(struct gpio_chip *gc, void *data)
>  {
> -	return ACPI_HANDLE_FWNODE(gc->fwnode) == data;
> +	return ACPI_HANDLE(&gc->gpiodev->dev) == data;
>  }

And after all this may be changed to device_match_acpi_handle().
I'll update it locally, but still wait for the Benjamin to test
this before sending a v2.

-- 
With Best Regards,
Andy Shevchenko