linux-kernel - Re: [PATCH v2] drivers: use free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aa29acfe-0973-54dc-a4d8-2b0f06dc805c@cambridgegreys.com>
Date:   Mon, 3 Jul 2023 14:19:38 +0100
From:   Anton Ivanov <anton.ivanov@...bridgegreys.com>
To:     Minjie Du <duminjie@...o.com>, richard@....at,
        johannes@...solutions.net, sfr@...b.auug.org.au,
        linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org,
        11162212@...o.com
Cc:     opensource.kernel@...o.com
Subject: Re: [PATCH v2] drivers: use free_netdev before return



On 03/07/2023 14:11, Minjie Du wrote:
> We will replace the old version of
> undo_user_init and use out_free_netdev
> 
> Signed-off-by: Minjie Du <duminjie@...o.com>
> ---
>   arch/um/drivers/vector_kern.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> index af7f6fd4c..7ae6ab8df 100644
> --- a/arch/um/drivers/vector_kern.c
> +++ b/arch/um/drivers/vector_kern.c
> @@ -1646,7 +1646,7 @@ static void vector_eth_configure(
>   	err = register_netdevice(dev);
>   	rtnl_unlock();
>   	if (err)
> -		goto out_undo_user_init;
> +		goto out_free_netdev;
>   
>   	spin_lock(&vector_devices_lock);
>   	list_add(&device->list, &vector_devices);
> @@ -1654,9 +1654,6 @@ static void vector_eth_configure(
>   
>   	return;
>   
> -out_undo_user_init:
> -	free_netdev(dev);
> -	return;
>   out_free_netdev:
>   	free_netdev(dev);
>   out_free_device:

Acked-By: "Anton Ivanov" <anton.ivanov@...bridgegreys.com>

-- 
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/