linux-kernel - Re: [PATCH] media: mediatek: vcodec: Add a flag to indicate vdec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4bd5aad43622742f1078f8bc4167803ed20f6a68.camel@mediatek.com>
Date:   Mon, 3 Jul 2023 04:11:12 +0000
From:   Irui Wang (王瑞) <Irui.Wang@...iatek.com>
To:     "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        Maoguang Meng (孟毛广) 
        <Maoguang.Meng@...iatek.com>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Yunfei Dong (董云飞) 
        <Yunfei.Dong@...iatek.com>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH] media: mediatek: vcodec: Add a flag to indicate vdec_fb
 finding status

Dear all,

A new patch v2 has been sent: 
https://patchwork.kernel.org/project/linux-media/list/?series=761892

current patch is superseded and can be abandoned.

Thank you very much

On Sat, 2023-07-01 at 17:05 +0800, Irui Wang wrote:
> "fb_use_list" is vp9 stateful decoder driver to store current
> used or referenced frame buffer, and "fb_free_list" is used to
> store current available to be freed frame buffer. When the
> target frame buffer cannot be found in "fb_use_list", "NULL"
> should be returned to prevent unexpected frame buffer from being
> placed into "fb_free_list".
> 
> Signed-off-by: Irui Wang <irui.wang@...iatek.com>
> ---
>  drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git
> a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c
> b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c
> index 70b8383f7c8e..e77d5a2452c1 100644
> --- a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c
> @@ -220,15 +220,21 @@ static struct vdec_fb
> *vp9_rm_from_fb_use_list(struct vdec_vp9_inst
>  {
>  	struct vdec_fb *fb = NULL;
>  	struct vdec_fb_node *node;
> +	bool found = false;
>  
>  	list_for_each_entry(node, &inst->fb_use_list, list) {
>  		fb = (struct vdec_fb *)node->fb;
>  		if (fb->base_y.va == addr) {
>  			list_move_tail(&node->list,
>  				       &inst->available_fb_node_list);
> +			found = true;
>  			break;
>  		}
>  	}
> +
> +	if (!found)
> +		fb = NULL;
> +
>  	return fb;
>  }
>