linux-kernel - Re: [PATCH v1] arch: free dev before return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMo8BfKe1nR+UP1WiUWFX0E7GSEfHsF8bZapsUYu3NFTnA8_AQ@mail.gmail.com>
Date:   Mon, 3 Jul 2023 10:05:39 -0700
From:   Max Filippov <jcmvbkbc@...il.com>
To:     Minjie Du <duminjie@...o.com>
Cc:     chris@...kel.net, sfr@...b.auug.org.au,
        linux-kernel@...r.kernel.org, 11162212@...o.com,
        opensource.kernel@...o.com
Subject: Re: [PATCH v1] arch: free dev before return

On Mon, Jul 3, 2023 at 7:19 AM Max Filippov <jcmvbkbc@...il.com> wrote:
> On Mon, Jul 3, 2023 at 5:33 AM Minjie Du <duminjie@...o.com> wrote:
> >
> > We fixed a bug where the variable dev
> > was not freed before return.
> >
> > Signed-off-by: Minjie Du <duminjie@...o.com>
> > ---
> >  arch/xtensa/platforms/iss/network.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> Applied to my xtensa tree with the following commit message:
>
>    xtensa: ISS: fix etherdev leak in error return path
>
>    iss_net_configure frees etherdev in all error return paths except one
>    where register_netdevice fails. Add missing free_netdev to that path.
>

After testing it I realized that in that error return path the etherdev is
freed by the iss_net_pdev_release callback and that this patch
introduces freeing an active timer on that path. I've dropped this patch
and committed another one that adds a comment about what's going
on at that place.

-- 
Thanks.
-- Max