linux-kernel - Re: [PATCH] xtensa: ISS: fix etherdev leak in error return path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAMo8Bf+ABwfqfi2hnyCdwooiogN7JMvq_tS0ZDYkytkYZ5gE9w@mail.gmail.com>
Date:   Mon, 3 Jul 2023 10:11:28 -0700
From:   Max Filippov <jcmvbkbc@...il.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Minjie Du <duminjie@...o.com>, kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>, opensource.kernel@...o.com,
        11162212@...o.com, Chris Zankel <chris@...kel.net>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Yang Yingliang <yangyingliang@...wei.com>
Subject: Re: [PATCH] xtensa: ISS: fix etherdev leak in error return path

On Mon, Jul 3, 2023 at 9:02 AM Markus Elfring <Markus.Elfring@....de> wrote:
>
> > > We fixed a bug where the variable dev
> > > was not freed before return.
> …
> > >  arch/xtensa/platforms/iss/network.c | 1 +
> …
> > Applied to my xtensa tree with the following commit message:
> >
> >    xtensa: ISS: fix etherdev leak in error return path
> >
> >    iss_net_configure frees etherdev in all error return paths except one
> >    where register_netdevice fails. Add missing free_netdev to that path.
>
> * Did you add the tag “Fixes” because of the completed resource cleanup
>   for the implementation of the function “iss_net_configure”?
>
> * How do you think about to replace any statements by the source code
>   “goto err_free_netdev;” here?

I've scrapped that patch and committed the other one instead. See

https://lore.kernel.org/lkml/CAMo8BfKe1nR+UP1WiUWFX0E7GSEfHsF8bZapsUYu3NFTnA8_AQ@mail.gmail.com/
https://lore.kernel.org/lkml/20230703170335.1340104-1-jcmvbkbc@gmail.com/

-- 
Thanks.
-- Max