linux-kernel - Re: [mm] 408579cd62: WARNING:suspicious_RCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-ce7af44f-732e-4a48-adb4-62deb17b3eb9@palmer-ri-x1c9>
Date:   Mon, 03 Jul 2023 11:11:27 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...osinc.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
CC:     Marc Zyngier <maz@...nel.org>, Conor Dooley <conor@...nel.org>,
        apatel@...tanamicro.com, oliver.sang@...el.com,
        Liam.Howlett@...cle.com, linux-kernel@...r.kernel.org,
        lkp@...ts.01.org, lkp@...el.com
Subject:     Re: [mm] 408579cd62: WARNING:suspicious_RCU_usage

On Mon, 03 Jul 2023 10:46:55 PDT (-0700), Linus Torvalds wrote:
> On Mon, 3 Jul 2023 at 10:34, Marc Zyngier <maz@...nel.org> wrote:
>>
>> Comparing with what we do on arm64, a less radical change would be to
>> move the IPI init after notify_cpu_starting(), which explicitly
>> enables RCU usage.
>
> Ack, that looks right to me.

I don't see anything wrong with it and it's passing my tests, but we've 
got a handful of ways to boot so it's all a bit messy and I might be 
messing something.

I'm still catching up a bit as I took both days off this weekend.  
Hopefully just an oversight in a bigger rafactoring, but I'll give it 
another look.

Marc: are you going to send that as a patch?