linux-kernel - Re: [PATCH v4] crypto: qat - Replace the if statement with min()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZKPHEYxkBeFbIBeR@smile.fi.intel.com>
Date:   Tue, 4 Jul 2023 10:15:29 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     You Kangren <youkangren@...o.com>
Cc:     Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Damian Muszynski <damian.muszynski@...el.com>,
        Adam Guerin <adam.guerin@...el.com>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Srinivas Kerekare <srinivas.kerekare@...el.com>,
        "open list:QAT DRIVER" <qat-linux@...el.com>,
        "open list:CRYPTO API" <linux-crypto@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        opensource.kernel@...o.com, luhongfei@...o.com
Subject: Re: [PATCH v4] crypto: qat - Replace the if statement with min()

On Tue, Jul 04, 2023 at 02:56:39PM +0800, You Kangren wrote:
> mark UWORD_CPYBUF_SIZE with U suffix to make the type the same with

You need to respect English grammar and punctuation.
Here should be

  Mark...

> words_num and replace the if statement with min() in 

(drop trailing space)

> qat_uclo_wr_uimage_raw_page() to make code shorter

...and here the period is missing.

Also, Haven't I given my tag? Why it's not added?

> Signed-off-by: You Kangren <youkangren@...o.com>
> ---

Where is the changelog from v3? What had been changed so far?

-- 
With Best Regards,
Andy Shevchenko