linux-kernel - Re: [PATCH v2] i2c: busses: i2c-nomadik: Remove a useless call in the remove function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230704073709.dzne7vcnsrksio2f@intel.intel>
Date:   Tue, 4 Jul 2023 09:37:09 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Dan Carpenter <dan.carpenter@...aro.org>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>, wsa@...nel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH v2] i2c: busses: i2c-nomadik: Remove a useless call in
 the remove function

Hi,

On Mon, Jul 03, 2023 at 03:54:42PM +0300, Dan Carpenter wrote:
> On Fri, Jun 30, 2023 at 11:23:28PM +0200, Christophe JAILLET wrote:
> > Since commit a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of
> > git://git.pengutronix.de/git/wsa/linux"), there is no more
> > request_mem_region() call in this driver.
> > 
> > So remove the release_mem_region() call from the remove function which is
> > likely a left over.
> > 
> > There is no details in the above commit log, but at its end we can read:
> >    Conflicts:
> > 	   drivers/i2c/busses/i2c-nomadik.c
> > 
> > This may explain why this call has been left here.
> > 
> > Fixes: a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux
> 
> The reason why you're so confused about this Merge commit is because
> it's completely unrelated to the bug.  :P  It should be:
> 
> Fixes: 235602146ec9 (i2c-nomadik: turn the platform driver to an amba driver)
> 
> When you look at that commit, you'll see that your patch is correct.

Yes, indeed I noticed the same but did not investigate further.
Please, also add:

Cc: <stable@...r.kernel.org> # v3.6+

Andi