linux-kernel - Re: [PATCH 2/2] ARM: dts: imx6: pfla02: Fix SD card reboot problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b382e51d-2f57-c4ab-7590-2083bd771abd@pengutronix.de>
Date:   Tue, 4 Jul 2023 10:15:55 +0200
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Andrej Picej <andrej.picej@...ik.com>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, upstream@...tec.de
Subject: Re: [PATCH 2/2] ARM: dts: imx6: pfla02: Fix SD card reboot problem

Hello Andrej,

On 04.07.23 10:03, Andrej Picej wrote:
> If regulator is not marked as always-on the regulator gets disabled on
> reboot breaking the next boot.

While this is ok as a fix, the real issue is that your system reset doesn't
restore PMIC rails to a good state. Are you perhaps doing a SoC-internal
reset only or have the PMIC misconfigured?

Cheers,
Ahmad

> 
> Signed-off-by: Andrej Picej <andrej.picej@...ik.com>
> ---
>  arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index 80adb2a02cc9..25d6a036d5b8 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -192,6 +192,7 @@ vdd_3v3_pmic_io_reg: ldo6 {
>  			vdd_sd0_reg: ldo9 {
>  				regulator-min-microvolt = <3300000>;
>  				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
>  			};
>  
>  			vdd_sd1_reg: ldo10 {

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |