[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20230704082706.1721-1-machel@vivo.com>
Date: Tue, 4 Jul 2023 16:26:56 +0800
From: Wang Ming <machel@...o.com>
To: Dinh Nguyen <dinguyen@...nel.org>, linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com, Wang Ming <machel@...o.com>
Subject: [PATCH v1] firmware:Fix an NULL vs IS_ERR() bug in probe
The devm_memremap() function returns error pointers.
It never returns NULL. Fix the check.
Signed-off-by: Wang Ming <machel@...o.com>
---
drivers/firmware/stratix10-svc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
index 2d6741261..cab11af28 100644
--- a/drivers/firmware/stratix10-svc.c
+++ b/drivers/firmware/stratix10-svc.c
@@ -756,7 +756,7 @@ svc_create_memory_pool(struct platform_device *pdev,
paddr = begin;
size = end - begin;
va = devm_memremap(dev, paddr, size, MEMREMAP_WC);
- if (!va) {
+ if (IS_ERR(va)) {
dev_err(dev, "fail to remap shared memory\n");
return ERR_PTR(-EINVAL);
}
--
2.25.1
Powered by blists - more mailing lists