linux-kernel - Re: [PATCH v1 1/1] usb: musb: Use read_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbySh+XFUDnFWUQHULYag0hukJ_ogfSREPLvs1iV=YmwQ@mail.gmail.com>
Date:   Tue, 4 Jul 2023 11:08:41 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bin Liu <b-liu@...com>
Subject: Re: [PATCH v1 1/1] usb: musb: Use read_poll_timeout()

On Mon, Jul 3, 2023 at 2:19 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:

> Use read_poll_timeout() instead of open coding it.
> In the same time, fix the typo in the error message.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
(...)
> +       ret = read_poll_timeout(gpiod_get_value, reg, !reg, 1000, 100000, true,
> +                               glue->intpin);

Wow that's really cool. I had no idea that you could use read_poll_timeout()
together with gpiod_get_value() like this!

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij