linux-kernel - RE: [PATCH/RFT] pinctrl: renesas: rzv2m: Handle non-unique subnode names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Jul 2023 09:13:55 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>
CC:     Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH/RFT] pinctrl: renesas: rzv2m: Handle non-unique subnode
 names

Hi Linus W,

> Subject: Re: [PATCH/RFT] pinctrl: renesas: rzv2m: Handle non-unique
> subnode names
> 
> On Mon, Jul 3, 2023 at 5:07 PM Geert Uytterhoeven
> <geert+renesas@...der.be> wrote:
> 
> > The eMMC and SDHI pin control configuration nodes in DT have subnodes
> > with the same names ("data" and "ctrl").  As the RZ/V2M pin control
> > driver considers only the names of the subnodes, this leads to
> > conflicts:
> >
> >     pinctrl-rzv2m b6250000.pinctrl: pin P8_2 already requested by
> 85000000.mmc; cannot claim for 85020000.mmc
> >     pinctrl-rzv2m b6250000.pinctrl: pin-130 (85020000.mmc) status -22
> >     renesas_sdhi_internal_dmac 85020000.mmc: Error applying setting,
> > reverse things back
> >
> > Fix this by constructing unique names from the node names of both the
> > pin control configuration node and its child node, where appropriate.
> >
> > Reported by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
> > Fixes: 92a9b825257614af ("pinctrl: renesas: Add RZ/V2M pin and gpio
> > controller driver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > ---
> > Untested on real hardware.
> > The RZ/G2L pin control drivers needs a similar fix.
> 
> If I need to merge this for fixes it's be great if we could also include
> a fix for RX/G2L.
> 
> Anyway, I expect a pull request for renesas fixes or some explicit
> instruction on what to do when it's tested and confirmed working.

OK, I will prepare a similar patch for RZ/G2L and will test and confirm.

Cheers,
Biju