linux-kernel - Re: [PATCH 2/7] reset: meson-audio-arb: Convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Jul 2023 14:12:47 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Yangtao Li <frank.li@...o.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] reset: meson-audio-arb: Convert to
 devm_platform_ioremap_resource()

On 04/07/2023 14:02, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> ---
>   drivers/reset/reset-meson-audio-arb.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/reset/reset-meson-audio-arb.c b/drivers/reset/reset-meson-audio-arb.c
> index 6a3f6a6a3bbf..355e041214bd 100644
> --- a/drivers/reset/reset-meson-audio-arb.c
> +++ b/drivers/reset/reset-meson-audio-arb.c
> @@ -138,7 +138,6 @@ static int meson_audio_arb_probe(struct platform_device *pdev)
>   	struct device *dev = &pdev->dev;
>   	const struct meson_audio_arb_match_data *data;
>   	struct meson_audio_arb_data *arb;
> -	struct resource *res;
>   	int ret;
>   
>   	data = of_device_get_match_data(dev);
> @@ -154,8 +153,7 @@ static int meson_audio_arb_probe(struct platform_device *pdev)
>   	if (IS_ERR(arb->clk))
>   		return dev_err_probe(dev, PTR_ERR(arb->clk), "failed to get clock\n");
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	arb->regs = devm_ioremap_resource(dev, res);
> +	arb->regs = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(arb->regs))
>   		return PTR_ERR(arb->regs);
>   

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>