linux-kernel - Re: [PATCH 3/5] EDAC/synopsys: Convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Jul 2023 14:17:09 +0200
From:   Michal Simek <michal.simek@....com>
To:     Yangtao Li <frank.li@...o.com>, Borislav Petkov <bp@...en8.de>,
        Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Richter <rric@...nel.org>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] EDAC/synopsys: Convert to
 devm_platform_ioremap_resource()



On 7/4/23 12:18, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> ---
>   drivers/edac/synopsys_edac.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
> index f7d37c282819..620861fb5231 100644
> --- a/drivers/edac/synopsys_edac.c
> +++ b/drivers/edac/synopsys_edac.c
> @@ -1325,11 +1325,9 @@ static int mc_probe(struct platform_device *pdev)
>   	struct synps_edac_priv *priv;
>   	struct mem_ctl_info *mci;
>   	void __iomem *baseaddr;
> -	struct resource *res;
>   	int rc;
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	baseaddr = devm_ioremap_resource(&pdev->dev, res);
> +	baseaddr = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(baseaddr))
>   		return PTR_ERR(baseaddr);
>   

Reviewed-by: Michal Simek <michal.simek@....com>

Thanks,
Michal