[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHk-=wgy2q9viwq-bAqaq8X_WQHNqDsu1AzfeYXAcDQRZmCoAw@mail.gmail.com>
Date: Tue, 4 Jul 2023 06:37:32 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Vegard Nossum <vegard.nossum@...cle.com>
Cc: Luis Chamberlain <mcgrof@...nel.org>,
George Kennedy <george.kennedy@...cle.com>,
linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org,
Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>,
syzbot+9c2bdc9d24e4a7abe741@...kaller.appspotmail.com,
Johan Hovold <johan@...nel.org>,
Dan Williams <dan.j.williams@...el.com>,
Rudi Heitbaum <rudi@...tbaum.com>,
David Hildenbrand <david@...hat.com>
Subject: Re: [PATCH] module: always complete idempotent loads
On Tue, 4 Jul 2023 at 03:09, Vegard Nossum <vegard.nossum@...cle.com> wrote:
>
> Commit 9b9879fc0327 added a hashtable storing lists of concurrent module
> loads. However, it didn't fix up all the error paths in
> init_module_from_file(); this would lead to leaving the function while an
> on-stack 'struct idempotent' element is still in the hash table, which
> leads to all sorts of badness as spotted by syzkaller:
You are of course 100% right.
However, I'd rather just use a wrapper function and make this thing
much clearer. Like I should have done originally.
So I'd be inclined towards a patch like the attached instead. Works for you?
Linus
View attachment "patch.diff" of type "text/x-patch" (2367 bytes)
Powered by blists - more mailing lists