linux-kernel - Re: [PATCH v1] fs:smb:Fix unsigned expression compared with zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5fbf1cc-9b79-5fbb-a109-87679caffcc4@talpey.com>
Date:   Tue, 4 Jul 2023 09:58:22 -0400
From:   Tom Talpey <tom@...pey.com>
To:     Namjae Jeon <linkinjeon@...nel.org>, Wang Ming <machel@...o.com>
Cc:     Steve French <sfrench@...ba.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org,
        opensource.kernel@...o.com
Subject: Re: [PATCH v1] fs:smb:Fix unsigned expression compared with zero

On 7/4/2023 4:58 AM, Namjae Jeon wrote:
> 2023-07-04 16:40 GMT+09:00, Wang Ming <machel@...o.com>:
>> The return value of the ksmbd_vfs_getcasexattr() is signed.
>> However, the return value is being assigned to an unsigned
>> variable and subsequently recasted, causing warnings. Use
>> a signed type.
>>
>> Signed-off-by: Wang Ming <machel@...o.com>
> Acked-by: Namjae Jeon <linkinjeon@...nel.org>
> 
> Thanks for your patch!
> 

FYI, this is missing my previous Acked-by. The updated changelog
otherwise looks good.

Tom.