linux-kernel - Re: [PATCH] riscv: entry: Fixup do_trap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJF2gTTaeO_u1tuHyCmWKptvg=W52gLY2xue2DbnbC6kihPTog@mail.gmail.com>
Date:   Tue, 4 Jul 2023 10:44:20 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     arnd@...db.de, palmer@...osinc.com, tglx@...utronix.de,
        peterz@...radead.org, luto@...nel.org, conor.dooley@...rochip.com,
        heiko@...ech.de, jszhang@...nel.org, lazyparser@...il.com,
        falcon@...ylab.org, chenhuacai@...nel.org, apatel@...tanamicro.com,
        atishp@...shpatra.org, mark.rutland@....com, bjorn@...nel.org,
        palmer@...belt.com, bjorn@...osinc.com, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        stable@...r.kernel.org, Guo Ren <guoren@...ux.alibaba.com>
Subject: Re: [PATCH] riscv: entry: Fixup do_trap_break from kernel side

On Mon, Jul 3, 2023 at 6:29 PM Daniel Thompson
<daniel.thompson@...aro.org> wrote:
>
> On Sat, Jul 01, 2023 at 10:57:07PM -0400, guoren@...nel.org wrote:
> > From: Guo Ren <guoren@...ux.alibaba.com>
> >
> > The irqentry_nmi_enter/exit would force the current context into in_interrupt.
> > That would trigger the kernel to dead panic, but the kdb still needs "ebreak" to
> > debug the kernel.
> >
> > Move irqentry_nmi_enter/exit to exception_enter/exit could correct handle_break
> > of the kernel side.
>
> <snip>
>
> > Fixes: f0bddf50586d ("riscv: entry: Convert to generic entry")
> > Reported-by: Daniel Thompson <daniel.thompson@...aro.org>
> > Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>
> > Signed-off-by: Guo Ren <guoren@...nel.org>
> > Cc: stable@...r.kernel.org
>
> I pushed this though the kgdb test suite that originally found the
> problem (although it didn't occur to me when I reported it that
> the problem was nothing to do with kgdb ;-) ). So FWIW:
>
> Tested-by: Daniel Thompson <daniel.thompson@...aro.org>
Thx for the report & tested-by.

>
>
> Daniel.



-- 
Best Regards
 Guo Ren