linux-kernel - Re: [PATCH v2] wifi: rtw89: debug: fix error code in rtw89_debug_priv_send_h2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Jul 2023 12:22:14 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Zhang Shurong <zhang_shurong@...mail.com>, pkshih@...ltek.com
Cc:     kvalo@...nel.org, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] wifi: rtw89: debug: fix error code in
 rtw89_debug_priv_send_h2c_set()

On 7/4/23 11:55, Zhang Shurong wrote:
> If there is a failure during rtw89_fw_h2c_raw() rtw89_debug_priv_send_h2c
> should return negative error code instead of a positive value count.
> 
> Fix this bug by returning correct error code.
> 
> The changes in this version:
> - fix some compile error
> 
> Signed-off-by: Zhang Shurong <zhang_shurong@...mail.com>

I have two comments on the patch itself:

1) Whenever you have a fix for the code, you need to annotate it using the 
"Fixes: tag". See file Documentation/process/submitting-patches.rst in your 
source tree.

2) The version change stuff should be in the following order:

Signed-off-by: ....
---
v2 - fixed compile error
---
Body of patch.

Placing it where you did would cause the details of "making the sausage" be 
saved in the commit log. The reviewer and maintainer need to see it, but not the 
end user.

Larry