linux-kernel - Re: Rust for linux build error due to Clang (bindgen) version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kZeLs1oWbUeZtx3CkGQxMa3Qnn3neV_yEfC+T_D-xtww@mail.gmail.com>
Date:   Tue, 4 Jul 2023 20:28:40 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Yuta Hayama <hayama@...eo.co.jp>
Cc:     rust-for-linux@...r.kernel.org, llvm@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: Rust for linux build error due to Clang (bindgen) version

On Tue, Jul 4, 2023 at 11:06 AM Yuta Hayama <hayama@...eo.co.jp> wrote:
>
> I am a beginner in Rust and LLVM, so sorry if this is a rudimentary question.

No need to apologize!

> But I think this patch is still in the rust-dev branch of the rust-for-linux
> tree and has not been merged into the mainline. The current mainline kernel
> seems to have a issue where if the Clang is too new (16 or later), the build
> fails even though `make rustavailable` passes.

The upgrade to `bindgen` will be merged after the merge window is over.

> Does this mean we need something like max-tool-version.sh? But that might be
> a bit silly... If such "error occurs because the tool is too new" is repeated
> in the future, I feel that it is necessary to check not only the lower limit of
> the tool version, but also the upper limit.

`make rustavailable` already warns for "too new" versions for `rustc`
and `bindgen`. We could add something like that (as error or warning)
for `libclang` too, but that particular issue goes away with the
upgrade in place, so (at least for mainline) it is OK.

Cheers,
Miguel