[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <249aa741-4b1e-ebdc-471a-3e5a634fad32@intel.com>
Date: Wed, 5 Jul 2023 11:34:20 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Ben Dooks <ben.dooks@...ethink.co.uk>,
<linux-kernel@...r.kernel.org>, <linux-acpi@...r.kernel.org>
CC: <nvdimm@...ts.linux.dev>, <lenb@...nel.org>
Subject: Re: [PATCH] ACPI: NFIT: limit string attribute write
On 7/4/23 01:17, Ben Dooks wrote:
> If we're writing what could be an arbitrary sized string into an attribute
> we should probably use snprintf() just to be safe. Most of the other
> attriubtes are some sort of integer so unlikely to be an issue so not
> altered at this time.
>
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> ---
> drivers/acpi/nfit/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 9213b426b125..d7e9d9cd16d2 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1579,7 +1579,7 @@ static ssize_t id_show(struct device *dev,
> {
> struct nfit_mem *nfit_mem = to_nfit_mem(dev);
>
> - return sprintf(buf, "%s\n", nfit_mem->id);
> + return snprintf(buf, PAGE_SIZE, "%s\n", nfit_mem->id);
Why not just convert it to sysfs_emit()?
> }
> static DEVICE_ATTR_RO(id);
>
Powered by blists - more mailing lists