linux-kernel - Re: [PATCH v2 2/4] mm/memory: convert wp_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZKXMp84KxEvlsWKi@casper.infradead.org>
Date:   Wed, 5 Jul 2023 21:03:51 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Sidhartha Kumar <sidhartha.kumar@...cle.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        akpm@...ux-foundation.org
Subject: Re: [PATCH v2 2/4] mm/memory: convert wp_page_shared() to use folios

On Wed, Jul 05, 2023 at 12:43:33PM -0700, Sidhartha Kumar wrote:
> @@ -3375,7 +3375,7 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf)
>  		 */
>  		if (!vmf->page)
>  			return wp_pfn_shared(vmf);
> -		return wp_page_shared(vmf);
> +		return wp_page_shared(vmf, page_folio(vmf->page));
>  	}
>  
>  	if (vmf->page)

I was actually hoping you'd move:

        if (vmf->page)
                folio = page_folio(vmf->page);

up to immediately after the call to vm_normal_page(), and avoid even
this call to page_folio().