| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20230705204314.89800-1-paul@crapouillou.net>
Date: Wed, 5 Jul 2023 22:42:51 +0200
From: Paul Cercueil <paul@...pouillou.net>
To: Wolfram Sang <wsa@...nel.org>
Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
Paul Cercueil <paul@...pouillou.net>,
Elie Morisse <syniurge@...il.com>,
Shyam Sundar S K <shyam-sundar.s-k@....com>,
Ray Jui <rjui@...adcom.com>,
Scott Branden <sbranden@...adcom.com>,
Kamal Dasu <kdasu.kdev@...il.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>,
Florian Fainelli <f.fainelli@...il.com>,
Bartosz Golaszewski <brgl@...ev.pl>,
Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Jan Dabros <jsd@...ihalf.com>,
Jean Delvare <jdelvare@...e.com>,
Qii Wang <qii.wang@...iatek.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Linus Walleij <linus.walleij@...aro.org>,
Peter Korsgaard <peter@...sgaard.com>,
Andrew Lunn <andrew@...n.ch>,
Vladimir Zapolskiy <vz@...ia.com>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Wolfram Sang <wsa+renesas@...g-engineering.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Alim Akhtar <alim.akhtar@...sung.com>,
Conghui Chen <conghui.chen@...el.com>,
Viresh Kumar <viresh.kumar@...aro.org>,
Peter Rosin <peda@...ntia.se>,
linux-arm-kernel@...ts.infradead.org,
linux-arm-msm@...r.kernel.org, linux-mediatek@...ts.infradead.org,
linux-renesas-soc@...r.kernel.org,
linux-samsung-soc@...r.kernel.org,
virtualization@...ts.linux-foundation.org
Subject: [PATCH 00/23] i2c: Use new PM macros
Hi Wolfram,
This patchset converts the I2C subsystem to use the PM macros that were
introduced in v5.17, which allow the dev_pm_ops and related callbacks to
be automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.
The point of this, is that all this code is now compiled independently
of any Kconfig option, which makes bugs and regressions easier to catch.
This continues the work that has been started in other subsystems (DRM,
IIO, watchdog).
As an added bonus, the diff is 71+/192-, that means less code you will
have to maintain ;)
The patches generally don't change the behaviour, with a few exceptions,
that are documented in the corresponding patches.
I would like to draw the attention to a few patches in particular:
- [01/23] the driver most likely does something that it shouldn't do
(use the same callbacks for runtime PM and system PM). The patch does
not change this behaviour but I have questions.
- [11/23] uses platform_driver.{suspend,resume} instead of the regular
.driver.pm. I have no idea why it does that and I believe it doesn't
really have to.
- [18/23] I feel like the qup_i2c_suspend / qup_i2c_resume don't really
need to exist, and the pm_runtime_force_suspend() /
pm_runtime_force_resume() helpers should be used instead, using the
DEFINE_RUNTIME_DEV_PM_OPS() macro.
Cheers,
-Paul
Paul Cercueil (23):
i2c: amd-mp2: Remove #ifdef guards for PM related functions
i2c: au1550: Remove #ifdef guards for PM related functions
i2c: iproc: Remove #ifdef guards for PM related functions
i2c: brcmstb: Remove #ifdef guards for PM related functions
i2c: davinci: Remove #ifdef guards for PM related functions
i2c: designware: Remove #ifdef guards for PM related functions
i2c: exynos5: Remove #ifdef guards for PM related functions
i2c: hix5hd2: Remove #ifdef guards for PM related functions
i2c: i801: Remove #ifdef guards for PM related functions
i2c: img-scb: Remove #ifdef guards for PM related functions
i2c: kempld: Remove #ifdef guards for PM related functions
i2c: lpc2k: Remove #ifdef guards for PM related functions
i2c: mt65xx: Remove #ifdef guards for PM related functions
i2c: nomadik: Remove #ifdef guards for PM related functions
i2c: ocores: Remove #ifdef guards for PM related functions
i2c: pnx: Remove #ifdef guards for PM related functions
i2c: pxa: Remove #ifdef guards for PM related functions
i2c: qup: Remove #ifdef guards for PM related functions
i2c: rcar: Remove #ifdef guards for PM related functions
i2c: s3c2410: Remove #ifdef guards for PM related functions
i2c: sh-mobile: Remove #ifdef guards for PM related functions
i2c: virtio: Remove #ifdef guards for PM related functions
i2c: mux: pca954x: Remove #ifdef guards for PM related functions
drivers/i2c/busses/i2c-amd-mp2-pci.c | 14 +++++--------
drivers/i2c/busses/i2c-amd-mp2-plat.c | 8 ++------
drivers/i2c/busses/i2c-amd-mp2.h | 2 --
drivers/i2c/busses/i2c-au1550.c | 15 +++-----------
drivers/i2c/busses/i2c-bcm-iproc.c | 10 +---------
drivers/i2c/busses/i2c-brcmstb.c | 8 +++-----
drivers/i2c/busses/i2c-davinci.c | 12 +++--------
drivers/i2c/busses/i2c-designware-platdrv.c | 22 ++++++---------------
drivers/i2c/busses/i2c-exynos5.c | 8 +++-----
drivers/i2c/busses/i2c-hix5hd2.c | 10 ++++------
drivers/i2c/busses/i2c-i801.c | 6 ++----
drivers/i2c/busses/i2c-img-scb.c | 13 ++++--------
drivers/i2c/busses/i2c-kempld.c | 9 ++-------
drivers/i2c/busses/i2c-lpc2k.c | 8 +-------
drivers/i2c/busses/i2c-mt65xx.c | 8 +++-----
drivers/i2c/busses/i2c-nomadik.c | 14 +++++--------
drivers/i2c/busses/i2c-ocores.c | 10 +++-------
drivers/i2c/busses/i2c-pnx.c | 12 ++++-------
drivers/i2c/busses/i2c-pxa.c | 8 +-------
drivers/i2c/busses/i2c-qup.c | 16 ++++-----------
drivers/i2c/busses/i2c-rcar.c | 10 ++--------
drivers/i2c/busses/i2c-s3c2410.c | 14 +++----------
drivers/i2c/busses/i2c-sh_mobile.c | 12 +++--------
drivers/i2c/busses/i2c-virtio.c | 8 ++------
drivers/i2c/muxes/i2c-mux-pca954x.c | 6 ++----
25 files changed, 71 insertions(+), 192 deletions(-)
--
2.40.1
Powered by blists - more mailing lists