linux-kernel - Re: [PATCH RESEND] input: cpcap-pwrbutton: remove initial kernel-doc notation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230705212845.w2yhqb75fqx6psim@mercury.elektranox.org>
Date:   Wed, 5 Jul 2023 23:28:45 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH RESEND] input: cpcap-pwrbutton: remove initial kernel-doc
 notation

Hi,

On Wed, Jul 05, 2023 at 12:28:50PM -0700, Dmitry Torokhov wrote:
> On Tue, Jul 04, 2023 at 02:08:21AM +0200, Sebastian Reichel wrote:
> > Hi,
> > 
> > On Mon, Jul 03, 2023 at 04:00:05PM -0700, Randy Dunlap wrote:
> > > Change the beginning "/**" in the file to "/*" since it is not a
> > > kernel-doc comment. This prevents a kernel-doc warning:
> > > 
> > > drivers/input/misc/cpcap-pwrbutton.c:2: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> > >  * CPCAP Power Button Input Driver
> > > 
> > > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > > Cc: Sebastian Reichel <sre@...nel.org>
> > > Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > > Cc: linux-input@...r.kernel.org
> > > ---
> > 
> > Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> 
> Applied, thank you.
> 
> BTW, the driver is missing SPDX annotation, Sebastian I wonder if you
> could send a patch addressing this (given you are the author it is
> better coming from you).

DONE: https://lore.kernel.org/all/20230705212231.631525-1-sre@kernel.org/

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)