linux-kernel - Re: [PATCH v1] drivers: usb: remove duplicate logical judgments in if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c74c932-83a1-6b9a-c799-347b25c1979b@xs4all.nl>
Date:   Wed, 5 Jul 2023 08:19:53 +0200
From:   Hans Verkuil <hverkuil-cisco@...all.nl>
To:     Minjie Du <duminjie@...o.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "open list:GO7007 MPEG CODEC" <linux-media@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Cc:     opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers: usb: remove duplicate logical judgments in if

Hi Minjie,

On 04/07/2023 12:40, Minjie Du wrote:
> Fix: delate duplicate judgments
> Does the judgment content of this if
> mean requesting confirmation twice?
> I'm not sure, Could you help check it out?
> Thank you!

>From what I can tell it tries to send the reset request a
second time if the first attempt fails. Fair enough.

So let's leave this as-is.

Regards,

	Hans

> 
> Signed-off-by: Minjie Du <duminjie@...o.com>
> ---
>  drivers/media/usb/go7007/go7007-usb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/usb/go7007/go7007-usb.c b/drivers/media/usb/go7007/go7007-usb.c
> index eeb85981e..c85e48e16 100644
> --- a/drivers/media/usb/go7007/go7007-usb.c
> +++ b/drivers/media/usb/go7007/go7007-usb.c
> @@ -653,8 +653,7 @@ static int go7007_usb_interface_reset(struct go7007 *go)
>  	if (usb->board->flags & GO7007_USB_EZUSB) {
>  		/* Reset buffer in EZ-USB */
>  		pr_debug("resetting EZ-USB buffers\n");
> -		if (go7007_usb_vendor_request(go, 0x10, 0, 0, NULL, 0, 0) < 0 ||
> -		    go7007_usb_vendor_request(go, 0x10, 0, 0, NULL, 0, 0) < 0)
> +		if (go7007_usb_vendor_request(go, 0x10, 0, 0, NULL, 0, 0) < 0)
>  			return -1;
>  
>  		/* Reset encoder again */