linux-kernel - Re: [03/12] sysfb: Do not include <linux/screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fc51f26-6844-6fa0-23be-81aa5ac50fd6@loongson.cn>
Date:   Wed, 5 Jul 2023 09:41:51 +0800
From:   Sui Jingfeng <suijingfeng@...ngson.cn>
To:     Thomas Zimmermann <tzimmermann@...e.de>, arnd@...db.de,
        deller@....de, daniel@...ll.ch, airlied@...il.com
Cc:     linux-hyperv@...r.kernel.org, linux-efi@...r.kernel.org,
        linux-ia64@...r.kernel.org, linux-sh@...r.kernel.org,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-mips@...r.kernel.org, sparclinux@...r.kernel.org,
        linux-riscv@...ts.infradead.org, Ard Biesheuvel <ardb@...nel.org>,
        linux-arch@...r.kernel.org, linux-hexagon@...r.kernel.org,
        linux-staging@...ts.linux.dev,
        Javier Martinez Canillas <javierm@...hat.com>,
        linux-csky@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
        loongarch@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-alpha@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [03/12] sysfb: Do not include <linux/screen_info.h> from sysfb
 header


On 2023/6/29 19:45, Thomas Zimmermann wrote:
> The header file <linux/sysfb.h> does not need anything from
> <linux/screen_info.h>. Declare struct screen_info and remove
> the include statements.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: Ard Biesheuvel <ardb@...nel.org>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Javier Martinez Canillas <javierm@...hat.com>
> Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>


Reviewed-by: Sui Jingfeng <suijingfeng@...ngson.cn>


> ---
>   include/linux/sysfb.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/sysfb.h b/include/linux/sysfb.h
> index c1ef5fc60a3cb..19cb803dd5ecd 100644
> --- a/include/linux/sysfb.h
> +++ b/include/linux/sysfb.h
> @@ -9,7 +9,8 @@
>   
>   #include <linux/kernel.h>
>   #include <linux/platform_data/simplefb.h>
> -#include <linux/screen_info.h>
> +
> +struct screen_info;
>   
>   enum {
>   	M_I17,		/* 17-Inch iMac */