linux-kernel - Re: [PATCH v1 1/6] dt-bindings: PCI: qcom: Add sa8775p compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <168854858595.4038242.5895489616920935149.robh@kernel.org>
Date:   Wed, 05 Jul 2023 03:16:27 -0600
From:   Rob Herring <robh@...nel.org>
To:     Mrinmay Sarkar <quic_msarkar@...cinc.com>
Cc:     Krzysztof Wilczyński <kw@...ux.com>,
        agross@...nel.org, Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        konrad.dybcio@...aro.org, linux-pci@...r.kernel.org,
        quic_nayiluri@...cinc.com, quic_shazhuss@...cinc.com,
        linux-phy@...ts.infradead.org, Bjorn Helgaas <bhelgaas@...gle.com>,
        quic_ramkri@...cinc.com, linux-arm-msm@...r.kernel.org,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        andersson@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        quic_nitegupt@...cinc.com, conor+dt@...nel.org, mani@...nel.org
Subject: Re: [PATCH v1 1/6] dt-bindings: PCI: qcom: Add sa8775p compatible


On Wed, 05 Jul 2023 13:47:06 +0530, Mrinmay Sarkar wrote:
> Add sa8775p platform to the binding.
> 
> Signed-off-by: Mrinmay Sarkar <quic_msarkar@...cinc.com>
> ---
>  .../devicetree/bindings/pci/qcom,pcie.yaml    | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/pci/qcom,pcie.yaml:753:17: [warning] wrong indentation: expected 14 but found 16 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1688545032-17748-2-git-send-email-quic_msarkar@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.