linux-kernel - Re: [PATCH 1/3] dt-bindings: arm: fsl: fix DEBIX binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Jul 2023 11:28:07 +0200
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Marco Felsch <m.felsch@...gutronix.de>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        shawnguo@...nel.org, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, marex@...x.de, frieder.schrempf@...tron.de
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: arm: fsl: fix DEBIX binding

On 05.07.23 08:35, Krzysztof Kozlowski wrote:
> On 04/07/2023 20:41, Marco Felsch wrote:
>> The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the
>> corresponding bindings by adding an own entry for it.
>>
>> Signed-off-by: Marco Felsch <m.felsch@...gutronix.de>
>> ---
>>  Documentation/devicetree/bindings/arm/fsl.yaml | 9 +++++++--
>>  1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index 15d4110840654..d9e763ef932e5 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -1019,8 +1019,6 @@ properties:
>>                - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC
>>                - fsl,imx8mp-evk            # i.MX8MP EVK Board
>>                - gateworks,imx8mp-gw74xx   # i.MX8MP Gateworks Board
>> -              - polyhex,imx8mp-debix      # Polyhex Debix boards
>> -              - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board
>>                - toradex,verdin-imx8mp     # Verdin iMX8M Plus Modules
>>                - toradex,verdin-imx8mp-nonwifi  # Verdin iMX8M Plus Modules without Wi-Fi / BT
>>                - toradex,verdin-imx8mp-wifi  # Verdin iMX8M Plus Wi-Fi / BT Modules
>> @@ -1054,6 +1052,13 @@ properties:
>>            - const: phytec,imx8mp-phycore-som         # phyCORE-i.MX8MP SoM
>>            - const: fsl,imx8mp
>>  
>> +      - description: Polyhex DEBIX i.MX8MP based SBCs
>> +        items:
>> +          - enum:
>> +              - polyhex,imx8mp-debix-model-a        # Polyhex Debix Model A Board
>> +          - const: polyhex,imx8mp-debix             # Polyhex Debix boards
> 
> Same comments as for patch #2. I think this should be rather deprecated
> - not a good pattern.

The middle compatible was my suggestion, because there's also the Debix Model
B Standard and Model B SE, which is the same board, but different SoC variant:

 Model A:          Commercial Temperature Grade
 Model B Standard: Industrial Temperature Grade
 Model B SE:       Industrial Temperature Grate, but i.MX8MP Lite
                   (No Neural/Video/Image accelerators).

As everything outside the SoC is the same, I wanted a generic board
compatible that bootloaders can match against. The SoMs should probably
not reuse it, but I think it should be kept (perhaps renamed?) for the
SBCs that don't utilize the Debix SoM.

Cheers,
Ahmad

> 
> Best regards,
> Krzysztof
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |