linux-kernel - Re: [PATCH/RFT] pinctrl: renesas: rzv2m: Handle non-unique subnode names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWmgvzYeHfiK6ZJ8Z2iYe0HOG7udPuAGQ6VCmEk9qJK8w@mail.gmail.com>
Date:   Wed, 5 Jul 2023 11:45:11 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Fabrizio Castro <fabrizio.castro.jz@...esas.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH/RFT] pinctrl: renesas: rzv2m: Handle non-unique subnode names

On Tue, Jul 4, 2023 at 5:48 PM Fabrizio Castro
<fabrizio.castro.jz@...esas.com> wrote:
> > From: Geert Uytterhoeven <geert+renesas@...der.be>
> > Subject: [PATCH/RFT] pinctrl: renesas: rzv2m: Handle non-unique subnode
> > names
> >
> > The eMMC and SDHI pin control configuration nodes in DT have subnodes
> > with the same names ("data" and "ctrl").  As the RZ/V2M pin control
> > driver considers only the names of the subnodes, this leads to
> > conflicts:
> >
> >     pinctrl-rzv2m b6250000.pinctrl: pin P8_2 already requested by
> > 85000000.mmc; cannot claim for 85020000.mmc
> >     pinctrl-rzv2m b6250000.pinctrl: pin-130 (85020000.mmc) status -22
> >     renesas_sdhi_internal_dmac 85020000.mmc: Error applying setting, reverse
> > things back
> >
> > Fix this by constructing unique names from the node names of both the
> > pin control configuration node and its child node, where appropriate.
> >
> > Reported by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
> > Fixes: 92a9b825257614af ("pinctrl: renesas: Add RZ/V2M pin and gpio
> > controller driver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
>
> Tested-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>

Thanks, will queue as a fix in renesas-pinctrl-for-v6.5.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds