linux-kernel - Re: [PATCH 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ae07f5c-ab40-7089-fe6b-9b85aa077d95@quicinc.com>
Date:   Wed, 5 Jul 2023 16:32:37 +0530
From:   Komal Bajaj <quic_kbajaj@...cinc.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC:     <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory
 region



On 7/5/2023 3:12 PM, Dmitry Baryshkov wrote:
> On Wed, 5 Jul 2023 at 10:06, Komal Bajaj <quic_kbajaj@...cinc.com> wrote:
>>
>>
>> On 7/5/2023 11:19 AM, Dmitry Baryshkov wrote:
>>> On Wed, 5 Jul 2023 at 08:40, Komal Bajaj <quic_kbajaj@...cinc.com> wrote:
>>>> Add missing reserved regions as described in QDU1000 memory map.
>>>>
>>>> Signed-off-by: Komal Bajaj <quic_kbajaj@...cinc.com>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++
>>>>    1 file changed, 26 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>>>> index 1d22f87fd238..3f5512ec0a90 100644
>>>> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>>>> @@ -448,6 +448,32 @@ &qupv3_id_0 {
>>>>           status = "okay";
>>>>    };
>>>>
>>>> +&reserved_memory{
>>>> +       #address-cells = <2>;
>>>> +       #size-cells = <2>;
>>>> +       ranges;
>>>> +
>>>> +       ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@...00000{
>>> no_underscores_in_node_names. Ever.
>>>
>>> Also, if you have checked other platforms, you'd have seen that other
>>> platforms use a much more generic node name for 'memory' nodes (which
>>> you should have used too).
>> These memory nodes are new to QDU platform, so will it be okay if I keep
>> these names without region suffix?
> Just use 'memory@...d'.

Sure, will update like that.

>
>> Thanks
>> Komal
>>
>>>> +               no-map;
>>>> +               reg = <0x0 0xe0000000 0x0 0x20000000>;
>>>> +       };
>>>> +
>>>> +       harq_buffer_mem:harq_buffer_region@...000000{
>>>> +               no-map;
>>>> +               reg = <0x8 0x0 0x0 0x80000000>;
>>>> +       };
>>>> +
>>>> +       tenx_sp_buffer_mem:tenx_sp_buffer_region@...000000{
>>>> +               no-map;
>>>> +               reg = <0x8 0x80000000 0x0 0x50000000>;
>>>> +       };
>>>> +
>>>> +       fapi_buffer_mem:fapi_buffer_region@...000000{
>>>> +               no-map;
>>>> +               reg = <0x8 0xd0000000 0x0 0x20000000>;
>>>> +       };
>>>> +};
>>>> +
>>>>    &sdhc {
>>>>           pinctrl-0 = <&sdc_on_state>;
>>>>           pinctrl-1 = <&sdc_off_state>;
>>>> --
>>>> 2.40.1
>>>>
>