linux-kernel - Re: [PATCH v1] m68k: apollo: Remove a duplicate assignment in dn_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mvm4jmisf6d.fsf@linux-m68k.org>
Date:   Wed, 05 Jul 2023 14:42:18 +0200
From:   Andreas Schwab <schwab@...ux-m68k.org>
To:     Minjie Du <duminjie@...o.com>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        linux-m68k@...ts.linux-m68k.org (open list:M68K ARCHITECTURE),
        linux-kernel@...r.kernel.org (open list),
        opensource.kernel@...o.com
Subject: Re: [PATCH v1] m68k: apollo: Remove a duplicate assignment in
 dn_timer_int

On Jul 05 2023, Minjie Du wrote:

> Delete a duplicate statement from this function implementation.
>
> Signed-off-by: Minjie Du <duminjie@...o.com>
> ---
>  arch/m68k/apollo/config.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/m68k/apollo/config.c b/arch/m68k/apollo/config.c
> index 42a8b8e2b..5645d2018 100644
> --- a/arch/m68k/apollo/config.c
> +++ b/arch/m68k/apollo/config.c
> @@ -173,7 +173,6 @@ irqreturn_t dn_timer_int(int irq, void *dev_id)
>  	legacy_timer_tick(1);
>  	timer_heartbeat();
>  
> -	x = *(volatile unsigned char *)(apollo_timer + 3);
>  	x = *(volatile unsigned char *)(apollo_timer + 5);

They are not the same: 3 != 5.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."