linux-kernel - Re: [PATCH] IB/hfi1: Fix potential deadlock on &sde->flushlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d7da8ef1-dde3-c7f6-3b78-460d5f8708d3@cornelisnetworks.com>
Date:   Wed, 5 Jul 2023 10:08:16 -0400
From:   Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>
To:     Chengfeng Ye <dg573847474@...il.com>,
        Leon Romanovsky <leon@...nel.org>
Cc:     jgg@...pe.ca, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] IB/hfi1: Fix potential deadlock on &sde->flushlist_lock

On 7/5/23 2:47 AM, Chengfeng Ye wrote:
>> Exactly, we already called to spin_lock_irqsave(), there is no value in
>> doing it twice.
> 
> Oh yeah, I just notice that the lock acquisition of &sde->flushlist_lock
> is always nested inside &sde->tail_lock due to the goto. Then it is true
> that no need for irq invariant lock/unlock on &sde->flushlist_lock.
> 
> Thanks much for your reply and your time.

Agree. Thanks Leon for looking at this. I was out of the office and just now
seen it.

-Denny