linux-kernel - Re: [PATCH v2 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJpqaqM1GL4_t=F0YP2wr-_2GetkD+gM54Ay=xUWRC9RQbg@mail.gmail.com>
Date:   Wed, 5 Jul 2023 17:33:01 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Komal Bajaj <quic_kbajaj@...cinc.com>, agross@...nel.org,
        andersson@...nel.org, konrad.dybcio@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved
 memory region

On Wed, 5 Jul 2023 at 17:24, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 05/07/2023 13:06, Komal Bajaj wrote:
> > Add missing reserved regions as described in QDU1000 memory map.
> >
> > Signed-off-by: Komal Bajaj <quic_kbajaj@...cinc.com>
> > ---
> >  arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> > index 1d22f87fd238..47e5e31dde23 100644
> > --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> > @@ -448,6 +448,28 @@ &qupv3_id_0 {
> >       status = "okay";
> >  };
> >
> > +&reserved_memory{
> > +     ecc_meta_data_mem: memory@...00000{
>
> Missing spaces before '{'. I was correcting this already:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=66b14154e278807811d67de9fb0d5cc76638d07b
> so it seems I need to keep doing the same.
>
> Anyway, the names should follow purpose, not "memory". See link from Konrad.

Yes, mea culpa. Please excuse me for the suggestion, I was looking at
the older device tree files.

>
>
> Best regards,
> Krzysztof
>


-- 
With best wishes
Dmitry