linux-kernel - Re: [PATCH V2 1/9] x86/hyperv: Add sev-snp enlightened guest static key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecd0aa48-90a4-50cb-7a4e-b7a6419576ce@gmail.com>
Date:   Wed, 5 Jul 2023 22:43:24 +0800
From:   Tianyu Lan <ltykernel@...il.com>
To:     "Michael Kelley (LINUX)" <mikelley@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        Dexuan Cui <decui@...rosoft.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "arnd@...db.de" <arnd@...db.de>
Cc:     Tianyu Lan <Tianyu.Lan@...rosoft.com>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>
Subject: Re: [PATCH V2 1/9] x86/hyperv: Add sev-snp enlightened guest static
 key

On 7/4/2023 10:17 PM, Michael Kelley (LINUX) wrote:
> From: Tianyu Lan <ltykernel@...il.com> Sent: Monday, June 26, 2023 8:23 PM
>>
>> Introduce static key isolation_type_en_snp for enlightened
>> sev-snp guest check.
>>
>> Signed-off-by: Tianyu Lan <tiala@...rosoft.com>
>> ---
>>   arch/x86/hyperv/ivm.c           | 11 +++++++++++
>>   arch/x86/include/asm/mshyperv.h |  3 +++
>>   arch/x86/kernel/cpu/mshyperv.c  |  9 +++++++--
>>   drivers/hv/hv_common.c          |  6 ++++++
>>   include/asm-generic/mshyperv.h  | 12 +++++++++---
>>   5 files changed, 36 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
>> index cc92388b7a99..5d3ee3124e00 100644
>> --- a/arch/x86/hyperv/ivm.c
>> +++ b/arch/x86/hyperv/ivm.c
>> @@ -409,3 +409,14 @@ bool hv_isolation_type_snp(void)
>>   {
>>   	return static_branch_unlikely(&isolation_type_snp);
>>   }
>> +
>> +DEFINE_STATIC_KEY_FALSE(isolation_type_en_snp);
>> +/*
>> + * hv_isolation_type_en_snp - Check system runs in the AMD SEV-SNP based
>> + * isolation enlightened VM.
>> + */
>> +bool hv_isolation_type_en_snp(void)
>> +{
>> +	return static_branch_unlikely(&isolation_type_en_snp);
>> +}
>> +
> 
> Vitaly had suggested some renaming of this and related variables and
> functions, which you had agreed to do.  But I don't see that renaming
> reflected in this patch or throughout the full patch set.
> 

Hi Michael:
	Thanks for your review. I am preparing a separating patchset to rework 
hv_isolation_type_en_snp() and hv_isolation_type_snp() according to 
Vitaly suggestion because it will touch more files and not affect 
SEV-SNP function.

Thanks.