linux-kernel - Re: [PATCH v2] kernel/trace: Fix cleanup logic of enable_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230705110534.1b79bf79@gandalf.local.home>
Date:   Wed, 5 Jul 2023 11:05:34 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Tzvetomir Stoyanov <tz.stoyanov@...il.com>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>, dan.carpenter@...aro.org,
        linux-trace-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kernel/trace: Fix cleanup logic of
 enable_trace_eprobe

On Wed, 5 Jul 2023 11:03:02 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Mon, 3 Jul 2023 06:47:12 +0300
> Tzvetomir Stoyanov <tz.stoyanov@...il.com> wrote:
> 
> > Ok, I'll send v3 with the counter, although I think it is a bit
> > overengineering - that optimization is in code that is unlikely to be
> > executed.  
> 
> It's not really over-engineering. We have this type of logic all over the
> kernel. When rolling back something, you really only want to rollback what
> you did, and not more. It prevents future bugs and makes things a bit more
> robust.
> 
> I'll go pick up v3 now.
> 

Masami, I see you delegated this patch to yourself. If you have something
you are working on to send to Linus soon, I'll let you take it.

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve