linux-kernel - Re: [PATCH v1] drivers: xilinx: Fix Judgment of the return value of the devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b5c6d42-c1a8-81a3-5947-7a720501ef15@amd.com>
Date:   Wed, 5 Jul 2023 09:47:41 -0700
From:   Lizhi Hou <lizhi.hou@....com>
To:     Minjie Du <duminjie@...o.com>, Brian Xu <brian.xu@....com>,
        "Raj Kumar Rampelli" <raj.kumar.rampelli@....com>,
        Vinod Koul <vkoul@...nel.org>,
        Michal Simek <michal.simek@....com>,
        "open list:XILINX XDMA DRIVER" <dmaengine@...r.kernel.org>,
        "moderated list:ARM/ZYNQ ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
CC:     <opensource.kernel@...o.com>
Subject: Re: [PATCH v1] drivers: xilinx: Fix Judgment of the return value of
 the devm_ioremap_resource function

Hi Minjie,

There was a patch created for this. Please see

https://lore.kernel.org/all/20230217062652.172480-1-yangyingliang@huawei.com/


Thanks,

Lizhi

On 7/4/23 05:04, Minjie Du wrote:
> IS_ERR() fix devm_ioremap_resource function return judge.
> Could you help check it out?
> Thank you!
>
> Signed-off-by: Minjie Du <duminjie@...o.com>
> ---
>   drivers/dma/xilinx/xdma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
> index 93ee298d5..ad5ff6335 100644
> --- a/drivers/dma/xilinx/xdma.c
> +++ b/drivers/dma/xilinx/xdma.c
> @@ -892,7 +892,7 @@ static int xdma_probe(struct platform_device *pdev)
>   	}
>   
>   	reg_base = devm_ioremap_resource(&pdev->dev, res);
> -	if (!reg_base) {
> +	if (IS_ERR(reg_base)) {
>   		xdma_err(xdev, "ioremap failed");
>   		goto failed;
>   	}