linux-kernel - Re: [PATCH V1 1/1] regulator: Add awinic,aw3750x.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <295e4cb9-0fa1-8370-72da-ade8123c90a5@linaro.org>
Date:   Wed, 5 Jul 2023 19:20:04 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     like@...nic.com, lgirdwood@...il.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        liweilei@...nic.com, liangdong@...nic.com, yijiangtao@...nic.com
Subject: Re: [PATCH V1 1/1] regulator: Add awinic,aw3750x.yaml

On 05/07/2023 13:52, Mark Brown wrote:
> On Wed, Jul 05, 2023 at 11:20:16AM +0200, Krzysztof Kozlowski wrote:
>> On 05/07/2023 10:19, like@...nic.com wrote:
>>> From: Ke Li <like@...nic.com>
> 
>>> +properties:
>>> +  compatible:
>>> +    const: awinic,aw3750x_led
> 
>> I don't understand why there is _led suffix. Isn't this regulator? Can
>> it be anything else?
> 
> Boost regulators are almost always used to drive LEDs for things like
> backlights.

Let me be a bit more precise - if this device can have multiple
functions, then the compatible usually has some suffixes (although no
underscores). If this device has only one feature - regardless whether
for backlight or for anything else - the compatible has only model.

Best regards,
Krzysztof