linux-kernel - Re: [PATCH] mfd: rk808: Make MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230705172621.iyg5tis5sfxekbqi@mercury.elektranox.org>
Date:   Wed, 5 Jul 2023 19:26:21 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Lee Jones <lee@...nel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: rk808: Make MFD_RK8XX tristate

Hi,

On Tue, Jul 04, 2023 at 03:07:48PM +0200, Geert Uytterhoeven wrote:
> There is no reason for MFD_RK8XX to be bool, all drivers that depend on
> it, or that select it, are tristate.
> 
> Fixes: c20e8c5b1203af37 ("mfd: rk808: Split into core and i2c")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Thanks, LGTM.

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>
Tested-by: Sebastian Reichel <sebastian.reichel@...labora.com>

-- Sebastian

> ---
>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6f5b259a6d6a0b9d..f6b519eaaa710e71 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1197,7 +1197,7 @@ config MFD_RC5T583
>  	  different functionality of the device.
>  
>  config MFD_RK8XX
> -	bool
> +	tristate
>  	select MFD_CORE
>  
>  config MFD_RK8XX_I2C
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)