linux-kernel - Re: [PATCH] udp6: add a missing call into udp_fail_queue_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f10c5eb17d6598def7ba17886e4e2e6e4aea07e0.camel@redhat.com>
Date:   Thu, 06 Jul 2023 19:37:50 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Ivan Babrou <ivan@...udflare.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-team@...udflare.com,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        David Ahern <dsahern@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Neil Horman <nhorman@...driver.com>,
        Satoru Moriya <satoru.moriya@....com>
Subject: Re: [PATCH] udp6: add a missing call into udp_fail_queue_rcv_skb
 tracepoint

Hi,

On Thu, 2023-07-06 at 10:22 -0700, Ivan Babrou wrote:
> The tracepoint has existed for 12 years, but it only covered udp
> over the legacy IPv4 protocol. Having it enabled for udp6 removes
> the unnecessary difference in error visibility.
> 
> Signed-off-by: Ivan Babrou <ivan@...udflare.com>
> Fixes: 296f7ea75b45 ("udp: add tracepoints for queueing skb to rcvbuf")
> ---
>  net/ipv6/udp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
> index e5a337e6b970..debb98fb23c0 100644
> --- a/net/ipv6/udp.c
> +++ b/net/ipv6/udp.c
> @@ -45,6 +45,7 @@
>  #include <net/tcp_states.h>
>  #include <net/ip6_checksum.h>
>  #include <net/ip6_tunnel.h>
> +#include <trace/events/udp.h>
>  #include <net/xfrm.h>
>  #include <net/inet_hashtables.h>
>  #include <net/inet6_hashtables.h>
> @@ -680,6 +681,7 @@ static int __udpv6_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
>  		}
>  		UDP6_INC_STATS(sock_net(sk), UDP_MIB_INERRORS, is_udplite);
>  		kfree_skb_reason(skb, drop_reason);
> +		trace_udp_fail_queue_rcv_skb(rc, sk);
>  		return -1;
>  	}

The patch looks correct and consistency is a nice thing, but I'm
wondering if we should instead remove the tracepoint from the UDP v4
code? We already have drop reason and MIBs to pin-point quite
accurately UDP drops, and the trace point does not cover a few UDPv4
spots (e.g. mcast). WDYT?

Thanks!

Paolo