linux-kernel - Re: [PATCH] x86: Remove the arch_calc_vm_prot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2d9bb146-e1ec-4fc2-a4bc-e1c67cfda723@app.fastmail.com>
Date:   Thu, 06 Jul 2023 22:22:07 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Thomas Huth" <thuth@...hat.com>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Ingo Molnar" <mingo@...hat.com>, "Borislav Petkov" <bp@...en8.de>,
        "Dave Hansen" <dave.hansen@...ux.intel.com>
Cc:     x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        "Nicolas Schier" <nicolas@...sle.eu>,
        "Masahiro Yamada" <masahiroy@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: Remove the arch_calc_vm_prot_bits() macro from the uapi

On Thu, Jul 6, 2023, at 21:02, Thomas Huth wrote:
> The arch_calc_vm_prot_bits() macro uses VM_PKEY_BIT0 etc. which are
> not part of the uapi, so the macro is completely useless for userspace.
> It is also hidden behind the CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS
> config switch which we shouldn't expose to userspace. Thus let's move
> this macro into a new internal header instead.
>
> Signed-off-by: Thomas Huth <thuth@...hat.com>

Fixes: 8f62c883222c9 ("x86/mm/pkeys: Add arch-specific VMA protection bits")
Reviewed-by: Arnd Bergmann <arnd@...db.de>

It looks like this was introduced right after the uapi split,
and probably is the result of an incorrect rebase.

     Arnd