linux-kernel - Re: [Intel-wired-lan] [PATCH net v2] ice: Unregister netdev and devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eda7b84e56123bce167a64133572440e6806ef1e.camel@redhat.com>
Date:   Thu, 06 Jul 2023 23:30:41 +0200
From:   Petr Oros <poros@...hat.com>
To:     netdev@...r.kernel.org
Cc:     pmenzel@...gen.mpg.de, intel-wired-lan@...ts.osuosl.org,
        jesse.brandeburg@...el.com, linux-kernel@...r.kernel.org,
        edumazet@...gle.com, anthony.l.nguyen@...el.com, kuba@...nel.org,
        pabeni@...hat.com, davem@...emloft.net
Subject: Re: [Intel-wired-lan] [PATCH net v2] ice: Unregister netdev and
 devlink_port only once

Petr Oros píše v Po 19. 06. 2023 v 12:58 +0200:
> Since commit 6624e780a577fc ("ice: split ice_vsi_setup into smaller
> functions") ice_vsi_release does things twice. There is unregister
> netdev which is unregistered in ice_deinit_eth also.
> 
> It also unregisters the devlink_port twice which is also unregistered
> in ice_deinit_eth(). This double deregistration is hidden because
> devl_port_unregister ignores the return value of xa_erase.
> 
Hi,

Is it possible to push this patch forward? I think the questions have
been answered. Or is something still unclear?

Regards,
Petr