linux-kernel - Re: linux-next: Tree for Jul 4 (drivers/net/ethernet/microchip/lan743x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2be9c20-4e0c-7880-ba0d-11b8f2c5404c@infradead.org>
Date:   Thu, 6 Jul 2023 16:29:26 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bryan Whitehead <bryan.whitehead@...rochip.com>,
        Network Development <netdev@...r.kernel.org>,
        UNGLinuxDriver@...rochip.com,
        Pavithra Sathyanarayanan <Pavithra.Sathyanarayanan@...rochip.com>
Subject: Re: linux-next: Tree for Jul 4
 (drivers/net/ethernet/microchip/lan743x_main.c)

Hi Simon,

On 7/6/23 14:45, Simon Horman wrote:
> + Pavithra Sathyanarayanan
> 
> On Tue, Jul 04, 2023 at 03:25:31AM -0700, Randy Dunlap wrote:
>>
>>
>> On 7/3/23 20:43, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Please do *not* add any v6.6 related stuff to your linux-next included
>>> branches until after v6.5-rc1 has been released.
>>>
>>> Changes since 20230703:
>>>
>>
>> on s390:
>>
>> s390-linux-ld: drivers/net/ethernet/microchip/lan743x_main.o: in function `lan743x_phy_open':
>> drivers/net/ethernet/microchip/lan743x_main.c:1514: undefined reference to `fixed_phy_register'
>>
>>
>> Full randconfig file is attached.
> 
> Thanks for the config.
> 
> I bisected this problem and it appears to be introduced by:
> 
> 624864fbff92 ("net: lan743x: add fixed phy support for LAN7431 device")
> 
> I wonder if the following change in dependencies is an appropriate fix for
> this problem.

Yes, that change fixes the build error. Thanks.

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

> 
> diff --git a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig
> index 24c994baad13..329e374b9539 100644
> --- a/drivers/net/ethernet/microchip/Kconfig
> +++ b/drivers/net/ethernet/microchip/Kconfig
> @@ -46,7 +46,7 @@ config LAN743X
>         tristate "LAN743x support"
>         depends on PCI
>         depends on PTP_1588_CLOCK_OPTIONAL
> -       select PHYLIB
> +       select FIXED_PHY
>         select CRC16
>         select CRC32
>         help
> 

-- 
~Randy