linux-kernel - Re: [PATCH v6 1/1] Input: gameport: add ISA and HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZKYMGMKuYC0/wOLN@google.com>
Date:   Wed, 5 Jul 2023 17:34:32 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Niklas Schnelle <schnelle@...ux.ibm.com>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/1] Input: gameport: add ISA and HAS_IOPORT
 dependencies

Hi Niklas,

On Mon, Jul 03, 2023 at 05:23:55PM +0200, Niklas Schnelle wrote:
> +static void gameport_setup_default_handlers(struct gameport *gameport)
> +{
> +	if (gameport->trigger && gameport->read)
> +		return;
> +
> +	if (!IS_ENABLED(CONFIG_HAS_IOPORT))
> +		dev_err(&gameport->dev,
> +			"I/O port access is required for %s (%s) but is not available\n",
> +			gameport->phys, gameport->name);

I combined these 2 conditions into one and applied, thank you.

-- 
Dmitry