[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <80b3c16b-fbf0-4c52-af1f-b9965cdeab5a@linaro.org>
Date: Thu, 6 Jul 2023 09:09:19 +0200
From: neil.armstrong@...aro.org
To: Dmitry Rokosov <ddrokosov@...rdevices.ru>,
gregkh@...uxfoundation.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
jbrunet@...libre.com, jirislaby@...nel.org, khilman@...libre.com,
martin.blumenstingl@...glemail.com
Cc: kelvin.zhang@...ogic.com, xianwei.zhao@...ogic.com,
kernel@...rdevices.ru, rockosov@...il.com,
linux-amlogic@...ts.infradead.org, linux-serial@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 5/7] tty: serial: meson: add independent uart_data for
A1 SoC family
On 05/07/2023 20:18, Dmitry Rokosov wrote:
> Implement separate uart_data to ensure proper devname value for the A1
> SoC family. Use 'ttyS' devname, as required by the A1 architecture,
> instead of the legacy gx architecture.
>
> Signed-off-by: Dmitry Rokosov <ddrokosov@...rdevices.ru>
> ---
> drivers/tty/serial/meson_uart.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 6a63184b8091..84cf10b0ca5c 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -818,6 +818,11 @@ static struct meson_uart_data meson_g12a_uart_data = {
> .has_xtal_div2 = true,
> };
>
> +static struct meson_uart_data meson_a1_uart_data = {
> + .uart_driver = &MESON_UART_DRIVER(ttyS),
> + .has_xtal_div2 = false,
> +};
> +
> static struct meson_uart_data meson_s4_uart_data = {
> .uart_driver = &MESON_UART_DRIVER(ttyS),
> .has_xtal_div2 = true,
> @@ -836,6 +841,10 @@ static const struct of_device_id meson_uart_dt_match[] = {
> .compatible = "amlogic,meson-s4-uart",
> .data = (void *)&meson_s4_uart_data,
> },
> + {
> + .compatible = "amlogic,meson-a1-uart",
> + .data = (void *)&meson_a1_uart_data,
> + },
> { /* sentinel */ },
> };
> MODULE_DEVICE_TABLE(of, meson_uart_dt_match);
With the real struct name:
Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
Powered by blists - more mailing lists