linux-kernel - [PATCH] drivers: bus: intel: Fix resource leaks in for_each_available_child_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230706072839.42905-1-luhongfei@vivo.com>
Date:   Thu,  6 Jul 2023 15:28:39 +0800
From:   Lu Hongfei <luhongfei@...o.com>
To:     Linus Walleij <linusw@...nel.org>, Imre Kaloz <kaloz@...nwrt.org>,
        Krzysztof Halasa <khalasa@...p.pl>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     opensource.kernel@...o.com, luhongfei@...o.com
Subject: [PATCH] drivers: bus: intel: Fix resource leaks in for_each_available_child_of_node loop

Ensure child node references are decremented properly
after loop complete.

Signed-off-by: Lu Hongfei <luhongfei@...o.com>
---
 drivers/bus/intel-ixp4xx-eb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bus/intel-ixp4xx-eb.c b/drivers/bus/intel-ixp4xx-eb.c
index f5ba6bee6fd8..cac8a8f5d7f9 100644
--- a/drivers/bus/intel-ixp4xx-eb.c
+++ b/drivers/bus/intel-ixp4xx-eb.c
@@ -398,6 +398,7 @@ static int ixp4xx_exp_probe(struct platform_device *pdev)
 		/* We have at least one child */
 		have_children = true;
 	}
+	of_node_put(child);
 
 	if (have_children)
 		return of_platform_default_populate(np, NULL, dev);
-- 
2.39.0